Skip to content

Implemented Typing Sounds#7

Open
PerepaMoorty wants to merge 3 commits intoacmpesuecc:mainfrom
PerepaMoorty:main
Open

Implemented Typing Sounds#7
PerepaMoorty wants to merge 3 commits intoacmpesuecc:mainfrom
PerepaMoorty:main

Conversation

@PerepaMoorty
Copy link
Copy Markdown

Added function to play a keyboard sound (Sound file is stored in the "sounds" folder)

@bunsamosa-bot
Copy link
Copy Markdown

bunsamosa-bot bot commented Oct 18, 2024

Thank you from Opening this Pull Request, @PerepaMoorty ! A Maintainer will review it soon!

@NavneetNayak
Copy link
Copy Markdown
Collaborator

@PerepaMoorty
image
there are some issues please fix them, you also need to propose a way to switch between different typing sounds

@PerepaMoorty
Copy link
Copy Markdown
Author

PerepaMoorty commented Oct 18, 2024

Okay, I will start working on these errors and adding a system to change sounds

Will three sound files suffice? @NavneetNayak

@NavneetNayak
Copy link
Copy Markdown
Collaborator

Yes three is fine

@PerepaMoorty
Copy link
Copy Markdown
Author

I have fixed the errors, Could you review it again? @NavneetNayak

@NavneetNayak
Copy link
Copy Markdown
Collaborator

NavneetNayak commented Oct 18, 2024

@PerepaMoorty sorry I didn't see this earlier this is an issue between windows and macOS
windows use \ and macOS uses / in path it would be great if you can implement compatibility between windows and Mac
else just adding the dependencies to the requirements file will be great

also based on the difficulty of the issue we've had to reassess and I will have to give you 100 points, sorry for marking the issue 200 in the first place, but we need to maintain some semblance of rankings , so I hope you understand. bonus if you can add compatibility.

@PerepaMoorty
Copy link
Copy Markdown
Author

PerepaMoorty commented Oct 18, 2024

Okay, I will try to add compatibilty for both windows and macOS

Sorry for the inconsistency!

I do not have a mac, So you have to test it out on a mac? @NavneetNayak

@PerepaMoorty
Copy link
Copy Markdown
Author

You can test it now?
@NavneetNayak

@NavneetNayak
Copy link
Copy Markdown
Collaborator

!bounty 200

@bunsamosa-bot
Copy link
Copy Markdown

bunsamosa-bot bot commented Oct 18, 2024

Assigned 200 Bounty points to user @PerepaMoorty !

@NavneetNayak
Copy link
Copy Markdown
Collaborator

Awesome I'll give you 200 anyway great job!

@PerepaMoorty
Copy link
Copy Markdown
Author

Thanks, So wait the 100 bounty thing, I didn;t understand

@PerepaMoorty
Copy link
Copy Markdown
Author

But thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants