Fix output format with prettier#9
Open
Pustur wants to merge 3 commits intoacmpesuecc:mainfrom
Pustur:output-format
Open
Fix output format with prettier#9Pustur wants to merge 3 commits intoacmpesuecc:mainfrom Pustur:output-format
Pustur wants to merge 3 commits intoacmpesuecc:mainfrom
Pustur:output-format
Conversation
Filtering out empty strings that can throw errors
Would cause an error with babel parser otherwise
avinash-vk
approved these changes
Oct 20, 2021
Collaborator
avinash-vk
left a comment
There was a problem hiding this comment.
This is such a neat solution!
Thanks a ton for your contribution @Pustur !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I saw that
prettierwas already a dependency of the project so I decided to use it programmatically to automatically format the output files.I decided to create a new file in the
utils/folder so that if the function needs to be updated we can do it in a single place.After the change a couple parts of the code would throw errors, but I fixed them in different commits so it should be easier to understand. If you need more info on my fixes please feel free to ask.
I hope you like this approach.
Fixes #6
Type of change
Checklist: