implement footer and navbar redesigns, fix bugs, and improve maintainability#26
Merged
spagechi merged 4 commits intoacmucsd:mainfrom Feb 19, 2026
Merged
Conversation
…ability Footer: - remove newsletter subscription - implement new desktop and mobile designs - make dynamic and resizable - add accessibility Navbar: - remove outdated application deadline countdown banner - implement new desktop and mobile designs - make dynamic and resizable Bug Fixes: - fix navbar width (horizontal scrolling issue) - update ACM Instagram handle (fix broken Instagram link) - fix mobile initial rendering on DevTools - fix component width issue happening at small viewport widths (add min-width of 320px to html and body in reset.scss) - fix import errors after updating next.js (image and vars.scss imports) Maintainability Improvements: - make major restructuring changes to footer TSX - move/nest styles in footer and navbar stylesheets - make spelling of gray consistent in global variable names - add a global function for calculating relative CSS property size used for resizing - switch to media queries for breakpoints for navbar to make adding more breakpoints easier - improve footer media query structure - calculate mobileNav margin-top instead of hardcoding
|
@spagechi is attempting to deploy a commit to the acmucsd Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
angela139
approved these changes
Feb 10, 2026
Collaborator
angela139
left a comment
angela139
left a comment
There was a problem hiding this comment.
Overall, looks good to me! I don't think the calc-relative-size function should be necessary but we can keep it for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Footer:
Navbar:
Bug Fixes:
Maintainability Improvements: