Skip to content

Conversation

@PyDev19
Copy link

@PyDev19 PyDev19 commented Jan 7, 2026

Changes

  • Started calling /register on the frontend to sign up users
  • Added a new structure for error handling where ideally every function should return a Result<T> just like just where the Result wrapper type handles for errors and on successes returns the T
  • Started calling the activity ping route on the backend to update the database on the users activity or inactivity

Problems

  • Ryan spent a lot of time today trying to fix the verification code stuff but I was still getting errors on it after pulling all the updates on main.
  • Consistent error handling might also be needed on the backend, I handling the inconsistencies with another error type on the frontend but I need to look into this more
  • Frontend code needs to be unified on how we are going to do API calls and error handling, I suggest to do it like how I did in this PR feel free to check it out I broke it down into a backend-esque style where a helper function in a pure typescript file does all the main work and frontend only needs to do error handling or displaying

Suggestions

  • We can use the proposed error type in every function
  • Move all API calls from TSX files to pure TS files in separate files, again check what I did in this PR
  • Move base API URL into the .env like how I did in this PR

@PyDev19 PyDev19 requested a review from ryanpolasky January 7, 2026 05:23
@ryanpolasky ryanpolasky self-assigned this Jan 7, 2026
@ryanpolasky ryanpolasky changed the title Fix/use register route related for both #52 and #49 Fix: Use register route for registration flow (#52 and #49) Jan 7, 2026
@ryanpolasky ryanpolasky added the Type: Bug Something isn't working label Jan 7, 2026
@ryanpolasky ryanpolasky added this to the MVP milestone Jan 7, 2026
@ryanpolasky ryanpolasky changed the title Fix: Use register route for registration flow (#52 and #49) fix: Use register route for registration flow (#52 and #49) Jan 7, 2026
Copy link
Contributor

@ryanpolasky ryanpolasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple tiny changes rq. Otherwise tho, really really strong PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

task: Ping activity endpoint on user login fix: Frontend no longer registers users in backend after Firebase signup

3 participants