Skip to content

Conversation

@GiangNPham
Copy link
Contributor

  1. Convert RMP's JSON data to SQL
  2. Backend query
  3. Frontend

@darichey
Copy link
Contributor

This is a lot of a data to add to the db. Can you share the before and after size of the db?

@GiangNPham
Copy link
Contributor Author

@darichey

This is a lot of a data to add to the db. Can you share the before and after size of the db?

2.4MB to 3.2MB

@GiangNPham
Copy link
Contributor Author

@FarhanJamil0001

Name not matched: I noticed that the names that are not matched all have middle name, but if a professor have 2 middle names then there's no pattern on which middle name to get rid of. For example, "Yu Chung Vincent Ng" -> remove second middle name, but for "Miguel Anguel Razo Razo" -> remove first middle name.

So what I did is create variations of the name when normalizing it -> Have to do few more queries than prev but more accurate

Copy link
Contributor

@FarhanJamil0001 FarhanJamil0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RMP prof matching has some more room for improvement in the future but we can tackle that in the summer. This is great and working for all of my test cases now. It's time to send it!

@FarhanJamil0001 FarhanJamil0001 merged commit f46c41b into master Mar 28, 2025
1 check passed
@FarhanJamil0001 FarhanJamil0001 deleted the feature/link_to_RMP branch March 28, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants