-
Notifications
You must be signed in to change notification settings - Fork 12
Rate my professor #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GiangNPham
commented
Mar 26, 2025
- Convert RMP's JSON data to SQL
- Backend query
- Frontend
|
This is a lot of a data to add to the db. Can you share the before and after size of the db? |
2.4MB to 3.2MB |
Co-authored-by: Mike Nguyen <34334226+DedsecKnight@users.noreply.github.com>
Co-authored-by: Mike Nguyen <34334226+DedsecKnight@users.noreply.github.com>
|
Name not matched: I noticed that the names that are not matched all have middle name, but if a professor have 2 middle names then there's no pattern on which middle name to get rid of. For example, "Yu Chung Vincent Ng" -> remove second middle name, but for "Miguel Anguel Razo Razo" -> remove first middle name. So what I did is create variations of the name when normalizing it -> Have to do few more queries than prev but more accurate |
FarhanJamil0001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RMP prof matching has some more room for improvement in the future but we can tackle that in the summer. This is great and working for all of my test cases now. It's time to send it!