Skip to content

Conversation

@emw8105
Copy link
Contributor

@emw8105 emw8105 commented Sep 20, 2025

I trust ruben to tell me if this is a breaking issue, but it seems to have fixed my build issues at least

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses TypeScript compilation and sql.js dependency issues by removing deprecated TypeScript configuration and updating sql.js initialization for Node.js environments.

  • Removes deprecated importsNotUsedAsValues compiler option from TypeScript configuration
  • Updates sql.js initialization to explicitly provide WASM binary for Node.js compatibility
  • Adds sql.js as a direct dependency to resolve build issues

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

File Description
tsconfig.build.json Removes deprecated TypeScript compiler option
db/src/import/index.ts Updates sql.js initialization with explicit WASM binary configuration
db/package.json Adds sql.js as a direct dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@emw8105
Copy link
Contributor Author

emw8105 commented Sep 20, 2025

grrr it's expecting the package-lock.json file i suppose

@emw8105 emw8105 requested a review from Copilot September 20, 2025 05:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@RubenOlano RubenOlano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍🏽

@RubenOlano RubenOlano merged commit 05cdc18 into master Sep 20, 2025
1 check passed
@RubenOlano RubenOlano deleted the fix/typescript-and-sql-js-issues branch September 20, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants