-
Notifications
You must be signed in to change notification settings - Fork 12
fixing dependency issues for building with typescript and sql.js #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses TypeScript compilation and sql.js dependency issues by removing deprecated TypeScript configuration and updating sql.js initialization for Node.js environments.
- Removes deprecated
importsNotUsedAsValuescompiler option from TypeScript configuration - Updates sql.js initialization to explicitly provide WASM binary for Node.js compatibility
- Adds sql.js as a direct dependency to resolve build issues
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tsconfig.build.json | Removes deprecated TypeScript compiler option |
| db/src/import/index.ts | Updates sql.js initialization with explicit WASM binary configuration |
| db/package.json | Adds sql.js as a direct dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
grrr it's expecting the package-lock.json file i suppose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
RubenOlano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works 👍🏽
I trust ruben to tell me if this is a breaking issue, but it seems to have fixed my build issues at least