Open
Conversation
*_pb2.py files can/should simply be regenerated by users to ensure compatibility with their local version of the protobuf toolset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes/untracks the auto-generated protobuf code and adds a script to easily/automatically regenerate them. This removes restrictions on the locally-installed version of the protobuf library, and is more in line with the recommended protobuf workflow (i.e., that gencode should not be tracked/committed to git repos, since it is the .proto files that are the single source of truth).
The included *_pb2.py files are incompatible with modern versions of the Python protobuf API, which is why this was a problem.