Open
Conversation
Making the hammerjs instance a property of cropbox so we can properly unbind the events in .remove();
Owner
|
this commit looks good, but the diff shows a dangling " var dragData;", why is that? |
jquery.cropbox.js
Outdated
|
|
||
| if (typeof $.fn.hammer === 'function' || typeof Hammer !== 'undefined') { | ||
| var hammerit, dragData; | ||
| this.hammerit; |
Owner
There was a problem hiding this comment.
you do not need to declare hammirit since you ar enot using the variable yet (i.e. this is not a "var" declaration)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making the hammerjs instance a property of cropbox so we can properly
unbind the events in .remove();
While creating the pause function (see other PR), i noticed that in the remove() function, doing "hammerit = Hammer(this.$image.get(0));" was actually creating a NEW instance of hammerjs on the element instead of retrieving the existing one.
After looking around, just storing the one with used to bind the events seemd to be the easiest way to do it, so this PR does just that.