Skip to content

allows arbitrary number of temp files to be written for image resizing #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ebbnormal wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allows arbitrary number of temp files to be written for image resizing #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0747555
allows arbitrary number of temp files to be written for image resizing
theophrastus144 Apr 26, 2017
1eaee79
style
theophrastus144 Apr 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions core/src/main/java/com/isbx/androidtools/media/ImageResizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
* </p>
*/
public class ImageResizer {

private static final int MAX_FILES = 10; // TODO handle files more intelligently
private static final int MAX_FILE_LIFESPAN = 86400000; // One day in milliseconds
private static final String FILE_NAME_FORMAT = "image%d.jpg";

private Context context;
Expand Down Expand Up @@ -198,8 +198,12 @@ public Uri scaleImage(Uri sourceUri, ImageResizeConfig.Dimension targetDimension

OutputStream os = null;
try {
if (savedFiles >= MAX_FILES) {
savedFiles = 0;
if (savedFiles >= 1) {
String lastFileName = String.format(Locale.US, FILE_NAME_FORMAT, savedFiles - 1);
long lastModified = context.getFileStreamPath(lastFileName).lastModified();
if (System.currentTimeMillis() - lastModified >= MAX_FILE_LIFESPAN) {
clearFiles();
}
}
String fileName = String.format(Locale.US, FILE_NAME_FORMAT, savedFiles++);
os = context.openFileOutput(fileName, Context.MODE_PRIVATE);
Expand Down Expand Up @@ -308,7 +312,7 @@ public static Bitmap scaleBitmap(Bitmap source, ImageResizeConfig.Dimension targ
* the current one.
*/
public void clearFiles() {
for (int i = 0; i < MAX_FILES; i++) {
for (int i = 0; i < savedFiles; i++) {
String fileName = String.format(Locale.US, FILE_NAME_FORMAT, i);
context.deleteFile(fileName);
}
Expand Down