Standardize shared adaptive staircase integration across games

[Copilot]

Difficulty progression was inconsistent across games: at least two games did not follow the shared rule of +1 level after 3 consecutive correct and -2 levels after 3 consecutive wrong. This PR completes the service adoption by ensuring all streak-based games use the shared staircase service, while preserving Otter Stop’s intended game-specific advancement semantics.

• Shared adaptive staircase service

  • Added app/components/adaptiveDifficultyService.js to centralize streak-based difficulty transitions.
  • Added focused unit coverage in app/components/tests/adaptiveDifficultyService.test.js.

• Game logic fixes and full service adoption

  • All streak-based games now leverage the shared service for staircase transitions:
    • app/games/otter-stop/game.js
    • app/games/field-of-view/game.js
    • app/games/directional-processing/game.js
    • app/games/sound-sweep/game.js
    • app/games/object-track/game.js
    • app/games/high-speed-memory/game.js
    • app/games/orbit-sprite-memory/game.js
    • app/games/fast-piggie/game.js
  • Preserved each game’s domain-specific difficulty representation while centralizing the streak transition logic.
  • Otter Stop follow-up fix: level-up progression is gated to correct no-go inhibitions (as intended), while any wrong response (false alarm on no-go or miss on go) contributes to the 3-wrong drop path.

• Behavioral test updates

  • Updated game tests to assert standardized staircase behavior where impacted:
    • app/games/otter-stop/tests/game.test.js
    • app/games/field-of-view/tests/game.test.js
  • Added/adjusted Otter Stop tests to enforce no-go-gated advancement and wrong-streak regression behavior.
  • Existing tests for other games validate unchanged functional behavior after refactor.
  • Added shared-service tests to lock in cross-game behavior contract.

• UI copy alignment (Field of View)

  • Updated player-facing guidance/messages to describe adaptive behavior clearly:
    • app/games/field-of-view/interface.html
    • app/games/field-of-view/index.js

const staircaseState = updateAdaptiveDifficultyState({
  value: level,
  wasCorrect: correct,
  consecutiveCorrect,
  consecutiveWrong,
  increaseAfter: 3,
  decreaseAfter: 3,
  harderStep: 1,
  easierStep: -2,
  minValue: 0,
});

Screenshot

[acrosman]

Looks like only the games in the issues were updated. But the whole point of a service like this is to support all games consistently. Ensure all games mirror the patterns by making sure they all leverage the service correctly.

[Copilot]

Looks like only the games in the issues were updated. But the whole point of a service like this is to support all games consistently. Ensure all games mirror the patterns by making sure they all leve...

Implemented in 57b201f (with follow-up alignment in 22b6732): all streak-based games now use the shared adaptiveDifficultyService for staircase transitions, including Directional Processing, Sound Sweep, Object Track, High Speed Memory, Orbit Sprite Memory, and Fast Piggie (Otter Stop and Field of View were already using it). Verified with targeted game tests, lint, full test suite, and final validation.

[acrosman]

Most games work right but Otter Stop wasn't integrated into the new service correctly. Now every response is graded as right or wrong to advance the level. It should wait until a no-go image comes around to check for advancing. Any wrong answer (selecting no-go or timing out on an otter) should be used for going back levels.

[acrosman]

This was important (the functionality not the comment).

[Copilot]

Fixed in 8ba811d (refined in dd5fe8a). The no-go-gated advancement behavior has been restored while keeping shared service integration for staircase transitions. Screenshot:

[acrosman]

This should not have been removed. The game should only count right answers for advancement when a no-go comes around.

[Copilot]

Implemented in 8ba811d (refined in dd5fe8a). Correct streak advancement is now gated to correct no-go trials again, and targeted Otter Stop tests were updated to enforce it. Screenshot:

[Copilot]

Most games work right but Otter Stop wasn't integrated into the new service correctly. Now every response is graded as right or wrong to advance the level. It should wait until a no-go image comes aro...

Addressed in 8ba811d (plus cleanup in dd5fe8a). Otter Stop now only advances on correct no-go inhibitions, while any wrong response (no-go false alarm or go timeout) contributes to the 3-wrong level drop path through the shared service. Screenshot:

Changes complete

[acrosman]

@copilot During release build the Windows build process throws an error:

D:\a\BrainSpeedExercises\BrainSpeedExercises\node_modules\.bin\jest:2
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
          ^^^^^^^

SyntaxError: missing ) after argument list
    at wrapSafe (node:internal/modules/cjs/loader:1763:18)
    at Module._compile (node:internal/modules/cjs/loader:1804:20)
    at Object..js (node:internal/modules/cjs/loader:1961:10)
    at Module.load (node:internal/modules/cjs/loader:1553:32)
    at Module._load (node:internal/modules/cjs/loader:1355:12)
    at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
    at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:154:5)
    at node:internal/main/run_main_module:33:47

Node.js v24.15.0
Error: Process completed with exit code 1.

How can we fix this?