Skip to content

Fixes to support full build process #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acrosman merged 4 commits into from
Apr 24, 2026
+7 −6
Merged

Fixes to support full build process #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57579ea
Adding windows to PR build for now.
acrosman Apr 23, 2026
738b0b9
Initial plan
Copilot Apr 23, 2026
f36b521
fix: use path.join for expected paths in progressManager tests to sup…
Copilot Apr 23, 2026
a4b44e8
Merge pull request #79 from acrosman/copilot/fix-progress-manager-tests
acrosman Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ macos-latest, ubuntu-latest ]
os: [ macos-latest, ubuntu-latest, windows-latest ]
steps:
- uses: actions/checkout@v6
- name: Use Node.js 24
Expand Down
11 changes: 6 additions & 5 deletions app/progress/progressManager.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/** @jest-environment node */
import { jest } from '@jest/globals';
import path from 'path';

const mockReadFile = jest.fn();
const mockWriteFile = jest.fn();
Expand Down Expand Up @@ -92,13 +93,13 @@ describe('saveProgress', () => {
await saveProgress('player1', { playerId: 'player1', games: {} });

expect(mockWriteFile).toHaveBeenCalledWith(
'/mock/userData/player1.json.tmp',
path.join('/mock/userData', 'player1.json.tmp'),
expect.any(String),
'utf8',
);
expect(mockRename).toHaveBeenCalledWith(
'/mock/userData/player1.json.tmp',
'/mock/userData/player1.json',
path.join('/mock/userData', 'player1.json.tmp'),
path.join('/mock/userData', 'player1.json'),
);
});

Expand All @@ -116,7 +117,7 @@ describe('saveProgress', () => {
await saveProgress('player1', { playerId: 'player1', games: {} });

expect(mockLogInfo).toHaveBeenCalledWith(
expect.stringContaining('/mock/userData/player1.json'),
expect.stringContaining(path.join('/mock/userData', 'player1.json')),
);
});
});
Expand All @@ -127,7 +128,7 @@ describe('resetProgress', () => {

await resetProgress('player1');

expect(mockUnlink).toHaveBeenCalledWith('/mock/userData/player1.json');
expect(mockUnlink).toHaveBeenCalledWith(path.join('/mock/userData', 'player1.json'));
});

test('resolves silently when file is missing (ENOENT)', async () => {
Expand Down
Loading