Draft
Conversation
This reverts commit fa80e68.
* main: (118 commits) Remove madge action Rebuild lock file Revert "Update ESlint to resolve security issues" Revert "ESLint and Jest updates" Adding madge Rebuild lock file ESLint and Jest updates Update ESlint to resolve security issues Safe npm updates Clean up loader message handling Correct status check list Nested conditional correction Adding handler for too many key errors Fix linting error Change ID type, convert more fields when too long Better recovery after second attempt on table. Update version number More output during processing Change base64 field to text Adding title to release template ...
* issue-54: Console modal Connect modal form meta tags and find layout More modal controls Adding pre-scrallable class BS5 Markup updates Package updates
Owner
Author
|
This should wait until after #196 is complete |
* main: (155 commits) Update package and package lock files Add edc tests Dedup object lists Adding EDC objects Add EDC objects, move to constants file Fix base sales cloud detection Add tests for SniffOrg and Recommended Objects Add feature detection and NPC features Generalize object list lookup array name Updates to mysql and sqlite3 Fix linting issue Update test values to conform with spellchecker Adding Knex mock and tests Bump node versions in workflows. Bump SF API version to 63 Bump JSForce and Electron (plus npm update) Adding jsforce Mock Bump tar-fs from 2.1.1 to 2.1.2 Bump undici from 6.20.1 to 6.21.1 NPM update ...
| throw new Error('Invalid Salesforce authentication URL'); | ||
| } | ||
|
|
||
| await shell.openExternal(authUrl); |
Check notice
Code scanning / Electronegativity
Review the use of openExternal
* main: (39 commits) Update packages. bump Electron Removed deprecated negativity Ignore any sfdx files that creep in. Bump lodash from 4.17.23 to 4.18.1 Bump @xmldom/xmldom from 0.8.10 to 0.8.12 Bump picomatch from 2.3.1 to 2.3.2 Bump flatted from 3.3.3 to 3.4.2 Adding lint fix to instructions Auto fixes to linting Adding lint fix command Expansion of Render tests Adding coverage for sqlite3 sf_calls Further improvements to sf_calls and tests. more sf calls expansion Expanded SF Calls test. Starts find.text.js Expanding sf_calls testing Adding tests for sf_calls. Setup main project file for better testing. Another try at language setup ...
…l into feature/add-oauth * 'feature/add-oauth' of github.com:acrosman/Salesforce2Sql:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will fix #6