[18.0][IMP] stachechart_mixin: make it possible to ignore some events in the has_allowed_event compute #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has_allowed_event compute
…has_allowed_event compute From #47
There is no need to leak this context handling to _get_sc_event_allowed_field_names, where this can be handled with a new argument.
Member
|
@ThomasBinsfeld @sbejaoui I found what still annoyed me with this PR and added a commit to fix it. Since the context key is only useful in the compute method, for which there is no other solution, it is better to handle it only there, and add an explicit argument to Is that ok for your use cases? |
Member
Author
|
LGTM |
sbidoul
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #47
Supersedes #51