Fix fire-and-forget async calls causing unhandled promise rejections during shutdown #1261
+73
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during shutdown Add .catch() handlers to all fire-and-forget async calls in Worker and Scheduler that were previously discarding Promise return values from timer callbacks. This prevents unhandled rejections when a shared Redis connection is closed during shutdown. Fixes #1260. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verify that Worker and Scheduler emit errors via the "error" event instead of causing unhandled promise rejections when Redis commands fail during ping/poll timer callbacks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
evantahler
deleted the
fix/unhandled-promise-rejections-during-shutdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.catch()handlers to all fire-and-forget async calls inWorkerandSchedulerthat previously discarded Promise return values from timer callbacks (setInterval/setTimeout). Caught errors are routed through the existing"error"event emitter.ping()andpoll()timer callbacks emit"error"events instead of becoming unhandled promise rejections.Fixes #1260
Test plan
redis.setto throw during ping interval, asserts error is emittedredis.setto throw during poll timer, asserts error is emitted🤖 Generated with Claude Code