set rustup profile to default #12214
Open
+3
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates Rust installation scripts to use the default profile (removing --profile=minimal) so that rustfmt and clippy are included automatically.
- Removed explicit
--profile=minimalflags from rustup installer invocations. - Deleted redundant
rustup component add rustfmt clippysteps. - Adjusted Windows script error handling remains; Ubuntu and macOS now rely on installer defaults.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| images/windows/scripts/build/Install-Rust.ps1 | Dropped --profile=minimal, removed manual component adds |
| images/ubuntu/scripts/build/install-rust.sh | Dropped --profile=minimal, removed manual component adds |
| images/macos/scripts/build/install-rust.sh | Dropped --profile=minimal, removed manual component adds |
Comments suppressed due to low confidence (2)
images/ubuntu/scripts/build/install-rust.sh:14
- Add an explicit check on the installer exit code (e.g.,
if [ $? -ne 0 ]; then exit 1; fi) after this line to ensure failures are caught.
curl -fsSL https://sh.rustup.rs | sh -s -- -y --default-toolchain=stable
images/macos/scripts/build/install-rust.sh:13
- Consider adding an error check immediately after this command (e.g.,
if [ $? -ne 0 ]; then echo "Rust installation failed"; exit 1; fi).
rustup-init -y --no-modify-path --default-toolchain=stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustupin GitHub Actions has been updated to1.28.2. Since1.28.2(rust-lang/rustup@f439f48), when a repository usesrust-toolchain.tomlto automatically install the nightly toolchain, rustup consults the profile specified in~/.rustup/settings.tomlinstead of defaulting to thedefaultprofile. This behavior is reasonable, as it aligns with howrustup toolchain installworks. However, it breaks usage for nightly toolchain users on GitHub Actions because the profile in GitHub Actions is set tominimal, which meansrustfmtandclippyare no longer installed automatically. This PR changes the profile todefaultto fix it.A temporary fix for those experiencing broken CI:
rustup set profile default