2024 reorganization #123
2024 reorganization #123
Conversation
This reverts commit 2d22f5f.
| <p> | ||
| A tetrahedron is a three-dimensional figure with four faces, each of which is a triangle. A picture of the tetrahedron <m>T</m> with vertices <m>(0,0,0)</m>, <m>(1,0,0)</m>, <m>(0,1,0)</m>, and <m>(0,0,1)</m> is shown in <xref ref="fig-mult_ints-general-PA-tetrahedron">Figure</xref>. If we place one vertex at the origin and let vectors <m>\va</m>, <m>\vb</m>, and <m>\vc</m> be determined by the edges of the tetrahedron that have initial point at the origin, then a formula that tells us the volume <m>V</m> of the tetrahedron is | ||
| <md number="yes" xml:id="eq-mult_ints-general-tetrahedron_volume"> | ||
| <men xml:id="eq-mult_ints-general-tetrahedron_volume"> |
There was a problem hiding this comment.
This should be reverted to my version. PreTeXt is deprecating men in favor of md with @number="yes".
| <men xml:id="eq-mult_ints-general-tetrahedron_volume"> | ||
| V = \frac{1}{6} \lvert \va \cdot (\vb \times \vc) \rvert | ||
| </md>. | ||
| </men>. |
There was a problem hiding this comment.
Need to revert the closing tag as well.
mitchkeller
left a comment
mitchkeller
left a comment
There was a problem hiding this comment.
@nelong See the one comment I made in a spot where men overwrite a md[number="yes"] change that I had written in Chapter 12. Other than that, it looks fine. (I thought I had spotted an image without a description, but then I realized it was in one of the large commented out chunks. I've been systematically removing those as isolated commits now, but we will have some cleanup to do in that regard after all the editing is done.)
reverting a silly change of mine. Don't remember why I did this
|
I reverted those changes. My bad
…On Thu, Jan 15, 2026 at 3:49 PM Mitchel T. Keller ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@nelong <https://github.com/nelong> See the one comment I made in a spot
where men overwrite a md[number="yes"] change that I had written in
Chapter 12. Other than that, it looks fine. (I thought I had spotted an
image without a description, but then I realized it was in one of the large
commented out chunks. I've been systematically removing those as isolated
commits now, but we will have some cleanup to do in that regard after all
the editing is done.)
—
Reply to this email directly, view it on GitHub
<#123 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG4HO4ZV4734C6N52W7B7A34HADOFAVCNFSM6AAAAACR2VT7F2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNRXG42DANZRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
|
Are you ready for me to merge this, @nelong? I don't have any other things to request changes on, but if you've got more changes you'll be pushing, I can wait to merge until you say it's ready to go. |
|
Your choice. I will be adding image descriptions over the next few days, so we can wait for that or we can merge now and deal with a bigger merge once you are done with Ch 12. You can also keep this open as a way to keep synced with your edits. |
|
I guess you can deploy from your working branch without me merging this, so I'm going to leave open until you feel like you've got through a batch of image descriptions. Tag me when you feel like it would be good to merge, and I will rebase my working branch for Ch 12 off of this before sending in a PR on that. |
2 participants
Merging in fixes for margins in sidebysides, webwork that is not generating, MK edits to Ch 12