Add failing test for single filter with multiple joins using wrong association alias #1628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a failing test to reproduce the bug where a single filter with multiple joins to the same table uses the wrong association alias.
Issue Description
When using Ransack with multiple joins to the same table and applying a filter to only one of the joined associations, the generated SQL uses the wrong table alias in the WHERE clause.
Problem Example
Consider this query:
Current (incorrect) behavior:
Expected (correct) behavior:
What This PR Does
This PR adds a failing test case that demonstrates the bug. The test:
Recommendation.joins(:person, :target_person).ransack({target_person_name_eq: 'Test'})
Impact
This bug affects queries where:
The bug can cause incorrect query results by filtering on the wrong table alias.
Note
This PR intentionally does not include a fix - it only adds the failing test case to reproduce the issue and serve as a specification for the expected behavior.
Original prompt
Fixes #1554
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.