Implement Read Device ID request and Write File Record request #1
Open
indianaMitko62 wants to merge 18 commits intoactiveshadow:mainfrom
Open
Implement Read Device ID request and Write File Record request #1indianaMitko62 wants to merge 18 commits intoactiveshadow:mainfrom
indianaMitko62 wants to merge 18 commits intoactiveshadow:mainfrom
Conversation
updated comment function codes description
changed creation of request payload. It must consist of 1-byte values instead 2-byte values to be able to communicate successfully with nanomodbus used bytes.Reader to read from response payload instead of indexing a byte array
Separated read device identification response parsing logic in a separate private method of the package. This way we can create different functions to call the private method with different read device id code. The user does need to know how the protocol request work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced MODBUS client to be able to send requests and parse responses of read Device Identification and Write File Record.
The Write File Record request is implemented in its entirety.
Read Device Identification functions supports all of its Read Device ID codes, but does not handle the More Follows functionality. It works
The Read Device ID codes can be specified automatically and manually.