Fix propagation of imported witnesses #2468
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teach `subImp` to run `importWits` for every dependency discovered in a module interface so protocol extensions from transitive imports are loaded into env.
Contributor
Author
|
I think this is on the right path but not enough, I think?? that importWits might be broken, can't quite place it, but think the env is different depending on whether we compiled a file, and thus including it in the env, vs if we read from .ty file.. marking as draft. |
Contributor
Author
|
Closing in preference of #2469. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach
subImpto runimportWitsfor every dependency discovered in a module interface so protocol extensions from transitive imports are loaded into env.