Improve error handling for back passes #2597
Merged
+155
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All user errors are, by design and definition, only in the front passes so during the last refactoring where those were broken out and run separately from the back passes, actually handling back passes were forgotten. The only errors from back passes are compilers bugs, so we don't pipe them through in such an elaborate way as for the front passes, but I pretty much forgot about them entirely with the consequence that we ended up completely burrying them. Not only that, but we counted any back jobs regardless of actual output result (success / done) as finished and so we moved on to the final zig build even when there were module failues in the back passes. That's fixed now. We also saw weird failures with truncated files. This comes from an error in CodeGen ( on the solver-next branch ), since Haskell is lazy and CodeGen is the last pass, its output is lazyily streamed - actually pulled out by the file, and so when we encountered the error relatively late, we ended up with truncated output. This was visible both in the .c and with --cgen - we did get slightly different locations for the truncation which I believe is related to buffering by some block size. Error are now properly surfaced and we don't proceed with futher compilation once we encounter errors in back passes. Files are also written atomically using a temporary file + rename, so we avoid torn files overall (even if the source reason in this case is fixed too).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db7512bcbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All user errors are, by design and definition, only in the front passes so during the last refactoring where those were broken out and run separately from the back passes, actually handling back passes were forgotten. The only errors from back passes are compilers bugs, so we don't pipe them through in such an elaborate way as for the front passes, but I pretty much forgot about them entirely with the consequence that we ended up completely burrying them. Not only that, but we counted any back jobs regardless of actual output result (success / done) as finished and so we moved on to the final zig build even when there were module failues in the back passes. That's fixed now.
We also saw weird failures with truncated files. This comes from an error in CodeGen ( on the solver-next branch ), since Haskell is lazy and CodeGen is the last pass, its output is lazyily streamed - actually pulled out by the file, and so when we encountered the error relatively late, we ended up with truncated output. This was visible both in the .c and with --cgen - we did get slightly different locations for the truncation which I believe is related to buffering by some block size.
Error are now properly surfaced and we don't proceed with futher compilation once we encounter errors in back passes. Files are also written atomically using a temporary file + rename, so we avoid torn files overall (even if the source reason in this case is fixed too).