refactor: factorial and binomial functions

[AJPfleger]

• remove extra parameter from factorial
• add overflow boundaries and confine to defined input parameters
• add compile time checks
• move the tests for binomial from polynomial-tests to math-tests
• rewrite the factorial function as a loop instead of a recursion. Since we don't do memoization.
• derive polynomials in a recursion

[github-actions]

📊: Physics performance monitoring for 8275c92

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ Truth tracking (KF refit)
• ✅ Truth tracking (GSF refit)
• ✅ CKF finding performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF track summary | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF finding performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF track summary | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF finding performance | trackfinding | single muon | default seeding
• ✅ CKF fitting performance | trackfinding | single muon | default seeding
• ✅ CKF track summary | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF finding performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF fitting performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF track summary | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF fitting performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF track summary | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF fitting performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF track summary | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ ML Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding
• 🔵️ Comparison - Truth tracking (GX2F vs KF)

[junggjo9]

I very strongly advert for the solution proposed in #4962

[andiwand]

just a few minor comments

I am inclined to put this in first as it seems simpler and ready compared to #4962 - what do you think @junggjo9 ? since this is ready and fixes a couple of issues. afterwards we can still iterate on the details

let me also ping @paulgessinger and @benjaminhuth on the error handling question

[junggjo9]

Do we now have 3 PRs open on this refactoring? Really?

[paulgessinger]

@junggjo9 I opened the last one only to show it to @andiwand. I'm happy to go with one of the others.

Can we converge this one though? I'd like to resolve the red X on the main branch if we can.

[AJPfleger]

After some discussion with @andiwand , I we came to the following idea:

• assert for unsupported parameters
• have a compile time guard too. initially thought of static_assert but that doesn't work on the variables, so the standard solution I found is a throw inside a std::is_const_evaluated() if

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
61.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud