feat: wrapper function for tgeo geometry building #4989
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am looking at updating our version of Acts and started with the geometry. The geometry building for TGeo is still within the ActsExamples namespace, which means anyone using TGeo still relies on the code. The core geometry building functionality is included in a function within
namespace {}inTGeoDetector.cpp, so it is effectively static and inaccessible to any outside files. This PR adds a wrapper function to theActsExamplesnamespace so that the functionality can be called outside. If there are better ways to handle this or achieve the same functionality, I would be interested to discuss