Add shadow DOM support for text spacing styles #33
Open
ritz078 wants to merge 2 commits intoactum:mainfrom
Open
Add shadow DOM support for text spacing styles #33ritz078 wants to merge 2 commits intoactum:mainfrom
ritz078 wants to merge 2 commits intoactum:mainfrom
Conversation
Inject styles into open shadow DOM boundaries via a content script that walks the DOM, finds shadow roots, and injects <style> elements. Uses MutationObserver to handle dynamically added shadow roots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, text spacing styles injected by the extension via chrome.scripting.insertCSS() only apply at the document level and cannot cross shadow DOM boundaries. Users visiting pages with web components (which use open shadow DOM) see no text spacing applied inside those components. This also affects shadow DOMs nested within iframes.
How it is solved
What this enables
Risks / notes
closes #32