add test cases for lam rpl issue fee and holiday calendar#10
Open
akhil-sirigineni wants to merge 3 commits intomasterfrom
Open
add test cases for lam rpl issue fee and holiday calendar#10akhil-sirigineni wants to merge 3 commits intomasterfrom
akhil-sirigineni wants to merge 3 commits intomasterfrom
Conversation
calendar(MFH). Added test cases to verify the functionality of Fee in PAM
calendar(MFH). Added test cases to verify the functionality of Fee in PAM
Collaborator
Author
|
Updated the test cases with the correct nominal interest rate(no rounding).Now you can review and merge the pull request |
fnparr
approved these changes
Oct 18, 2025
Collaborator
fnparr
left a comment
fnparr
left a comment
There was a problem hiding this comment.
The unit tests of lam32 and lam33 are no good. The rounding issue which previously caused nominalInterest to show as 0/0 when the actual value is 8% is now fixed. This provides significantly more convincing tests. I have also copy the actus-tests-lam.json file from updated actus-tests into the actus-core unit tests. Have built and successfully unit tested actus-core with this change and so will merge those updated unit tests into the master branch of actsu core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test cases for LAM RPL use case and also for the holidays
calendar(MFH).
Added test cases to verify the functionality of Fee in PAM