Skip to content

Demo schema not validated #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
acuderman wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Demo schema not validated #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aries_cloudagent/protocols/present_proof/dif/pres_exch_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ async def filter_schema(
applicable = False
for schema in schemas:
applicable = self.credential_match_schema(
credential=credential, schema_id=schema.uri
credential=credential, schema_id="https://w3id.org/citizenship#PermanentResident"
)
if schema.required and not applicable:
break
Expand Down
18 changes: 10 additions & 8 deletions aries_cloudagent/protocols/present_proof/v2_0/formats/dif/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,14 +197,14 @@ async def create_pres(
input_descriptor.constraint.limit_disclosure == "required"
)
uri_list = []
for schema in input_descriptor.schemas:
uri = schema.uri
if schema.required is None:
required = True
else:
required = schema.required
if required:
uri_list.append(uri)
# for schema in input_descriptor.schemas:
# uri = schema.uri
# if schema.required is None:
# required = True
# else:
# required = schema.required
# if required:
# uri_list.append(uri)
if len(uri_list) == 0:
uri_list = None
if limit_disclosure:
Expand Down Expand Up @@ -297,6 +297,8 @@ async def create_pres(
vcrecord_list,
vcrecord_ids_set,
) = await self.process_vcrecords_return_list(records, record_ids)
# print(records)
print(vcrecord_list)
record_ids = vcrecord_ids_set
credentials_list = credentials_list + vcrecord_list
except StorageNotFoundError as err:
Expand Down
6 changes: 4 additions & 2 deletions aries_cloudagent/protocols/present_proof/v2_0/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,8 +515,8 @@ async def present_proof_credentials_list(request: web.BaseRequest):
required = True
else:
required = schema.required
if required:
uri_list.append(uri)
#if required:
#uri_list.append(uri)
if len(uri_list) == 0:
uri_list = None
if limit_disclosure:
Expand Down Expand Up @@ -629,6 +629,8 @@ async def present_proof_credentials_list(request: web.BaseRequest):
outbound_handler,
)
credentials = list(indy_credentials) + dif_cred_value_list

print(credentials)
return web.json_response(credentials)


Expand Down
2 changes: 1 addition & 1 deletion demo/runners/faber.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ def generate_proof_request_web_request(
"uri": "https://www.w3.org/2018/credentials#VerifiableCredential"
},
{
"uri": "https://w3id.org/citizenship#PermanentResident"
"uri": "https://w3id.org/test#test"
},
],
"constraints": {
Expand Down