AC2-Ocelot-Sheung Wan (Melody) Wong#10
Open
MelodyW2022 wants to merge 15 commits intoada-ac2:mainfrom
Open
Conversation
| class Item: | ||
| pass No newline at end of file | ||
| def __init__(self, id=None, condition=0): | ||
| if id is None: |
There was a problem hiding this comment.
Clean code. This could also be a chance for a ternary operator
| class Vendor: | ||
| pass No newline at end of file | ||
| def __init__(self, inventory=None): | ||
| if inventory is None: |
There was a problem hiding this comment.
Another example of clean, readable code, which might be more pythonic with a ternary operator.
| def add(self, item): | ||
| self.inventory.append(item) | ||
| return item | ||
| def remove(self, item): |
There was a problem hiding this comment.
Small detail: it's nice to see consistent white space between functions, for readability :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.