Open
Conversation
| def __init__(self, id=None, condition=None, fabric=None) : | ||
| super().__init__(id, condition) | ||
| if fabric: | ||
| if type(fabric) is not str: |
There was a problem hiding this comment.
Nice extra error checking!
I would do this before the other code, so that the error is generated first, before extra work is unnecessarily done.
| def __init__(self, id=None, condition=None, type=None) : | ||
|
|
||
| super().__init__(id, condition) | ||
| if type: |
There was a problem hiding this comment.
This is clean code, though it could be a ternary operator.
|
|
||
| return f"An object of type Item with id {self.id}" | ||
|
|
||
| def condition_description(self): |
There was a problem hiding this comment.
Well done-- though now, you probably can see the advantages of a dict for this. O(1) lookup, vs, O(n) for the worse case of falling through n conditions in an if/else :)
| if my_item not in self.inventory or their_item not in b_vendor.inventory : | ||
| return False | ||
| else: | ||
| self.remove(my_item) |
There was a problem hiding this comment.
good use of making use of existing vendor functions, rather than re-implementing that logic here again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.