"Octothorpes - Elaine(SiOk) Sohn(she/her)"

[sioksohn]

No description provided.

[kelsey-steven-ada]

Great work Elaine! I've left a mix of suggestions and questions to consider for feedback. Please reply here on Github or reach out on Slack if there's anything I can clarify =]

[kelsey-steven-ada]

Nice use of inheritance across the child classes 👍

[kelsey-steven-ada]

It looks like Clothing and Decor use the parent class' get_category method, but Electronics has its own implementation. Can Electronics use the parent class too?

[kelsey-steven-ada]

Since we are using an f-string already, another option would be to call the superclass function from a placeholder:

return f"{super().__str__()}. It is made from {self.fabric} fabric."

[kelsey-steven-ada]

Nice solution, another option here could use conditional assignment:

# Assigns self.id to the parameter id if id is truthy, 
# otherwise assigns self.id the return value of uuid.uuid4().int
self.id = id if id else uuid.uuid4().int

[kelsey-steven-ada]

Nice handling for condition description! It looks like the code assumes that self.condition will always be an integer, but what if we allowed decimals like a condition of 3.5? How could we adapt our code to convert the decimal to an int we could use here, or alternately, change the if-statements to support decimals?

[kelsey-steven-ada]

Great use for enumerate! If we don't want to manually add the +1 to i, enumerate can take a second parameter that tells the counter i where to start: enumerate(self.inventory, start=1)

[kelsey-steven-ada]

This if-tree is pretty nested and we repeat our looping and no inventory code. If we first resolve what list of items we want to iterate over, then error handle if it is empty, we can remove some of the if-elses:

# If `category` is not empty or None, get a list of items with that category, 
# otherwise set `display_items` to `self.inventory`
display_items = self.get_by_category(category) if category else self.inventory
# The line above would be equivalent to
# if category:
#     display_items = self.get_by_category(category)
# else:
#     display_items = self.inventory

# We can now remove code that was repeated when the list of items was empty
if not display_items:
    print("No inventory to display.") 
    return

# If we've gotten here, there must be an inventory to print
for index, item in enumerate(display_items, start=1):
    print(f"{index}. {item}")

[kelsey-steven-ada]

Because we have implemented the __str__ method, this is one of the situations where python will implicitly call it for us, we don't need to wrap item in a call to str:

print(f"{i+1}. {item}")

[kelsey-steven-ada]

Nice assert, we definitely want to confirm our return value is None. We generally also want to confirm that there weren't side affects or changes to the input that we didn't intend. What could we check about the vendor's inventory to confirm that its content didn’t change?

[kelsey-steven-ada]

The feedback in wave 1 applies here as well, what else would be helpful to assert to ensure there were no unintended side effects?