Skip to content

Otters- Megan, Marjana, Lulu#39

Open
mckorling wants to merge 11 commits intoada-c17:masterfrom
mckorling:master
Open

Otters- Megan, Marjana, Lulu#39
mckorling wants to merge 11 commits intoada-c17:masterfrom
mckorling:master

Conversation

@mckorling
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@jbieniosek jbieniosek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Megan, Marjana and Lulu! Very clean, readable code throughout this project. Nice work with the multiple commits! This project is green.

Comment thread adagrams/game.py
Comment on lines +69 to +72
letter = random.choice(string.ascii_uppercase)
if available_pool[letter] - 1 >= 0:
result.append(letter)
available_pool[letter] = available_pool[letter] - 1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution!

Comment thread adagrams/game.py
def uses_available_letters(word, letter_bank):
pass
word = word.upper()
available_letters = letter_bank[:]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread adagrams/game.py
available_letters = letter_bank[:]
for letter in word:
if letter in available_letters:
available_letters.remove(letter)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread adagrams/game.py
word = word.upper()
points = 0
for letter in word:
points += SCORE_CHART[letter]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Comment thread adagrams/game.py
elif word_len == 10:
highest_word = word
elif word_len < highest_word_len:
highest_word = word
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one pass solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants