Conversation
kendallatada
left a comment
kendallatada
left a comment
There was a problem hiding this comment.
Hi Tori! Your submission has been scored as green. Please check your code to see the comments I left. Let me know if you have any questions. Nice work! :)
| pass No newline at end of file | ||
|
|
||
| def __init__(self, inventory = None): | ||
| '''Vendor class is instantiated''' |
| if not self.inventory or not other.inventory: | ||
| return False | ||
| else: | ||
| return self.swap_items(other, self.inventory[0], other.inventory[0]) |
There was a problem hiding this comment.
Nice usage of self.swap_items() ✨
|
|
||
| for item in self.inventory: | ||
| if item.category == category: | ||
| if item.condition > current_condition: |
There was a problem hiding this comment.
small note - you could combine these conditional statements on one line using the and keyword. So, if item.category == category and item.condition > condition:
| '''Item class is instantiated''' | ||
| def __init__(self, category=None, condition = 0, age = 0): | ||
| if not category: | ||
| category = "" |
There was a problem hiding this comment.
Strings are immutable so you can set an empty string as a default value in the parameters :)
| if self.condition == 4: | ||
| return f"basic" | ||
| if self.condition == 5: | ||
| return f"vibe" No newline at end of file |
There was a problem hiding this comment.
Lol @ "vibe"
small note - make sure to have a blank line at the end of all your Python files. It's convention.
| @pytest.mark.skip | ||
| @pytest.mark.integration_test | ||
| #@pytest.mark.skip | ||
| #@pytest.mark.integration_test |
There was a problem hiding this comment.
In the future, don't worry about commenting out @pytest.mark.integration. This decorator just specifies that these tests are integration tests so they should run after all the unit tests have been executed. :)
| class Clothing(Item): | ||
| '''Clothing class is instantiated and inherits from Item class''' | ||
|
|
||
| def __init__(self, category = "Clothing", condition = 0, age = 0): |
There was a problem hiding this comment.
small note - if all items for this child class should have their category attribute set to "Clothing", do we need to have category as a parameter in the constructor? This makes it possible for users to set the category to something else which could lead to unexpected problems in our application. Think about how you could update your code to make sure the category for this class is always set to "Clothing"
| class Decor(Item): | ||
| '''Decor class is instantiated and inherits from Item class''' | ||
|
|
||
| def __init__(self, category = "Decor", condition = 0, age = 0): |
There was a problem hiding this comment.
note about category parameter applies here too
| class Electronics(Item): | ||
| '''Electronics class is instantiated and inherits from Item class''' | ||
|
|
||
| def __init__(self, category = "Electronics", condition = 0, age = 0): |
There was a problem hiding this comment.
note about category parameter applies here too
2 participants
No description provided.