Move ASCII range checks to writeDigitAscii()#64
Open
dmadison wants to merge 2 commits intoadafruit:masterfrom
Open
Move ASCII range checks to writeDigitAscii()#64dmadison wants to merge 2 commits intoadafruit:masterfrom
dmadison wants to merge 2 commits intoadafruit:masterfrom
Conversation
This prevents the `writeDigitAscii()` function from reading outside the bounds of the font table. Values outside the printable range are printed as blanks.
caternuson
requested changes
Oct 8, 2021
| if ((c >= ' ') && (c <= 127)) { | ||
| writeDigitAscii(position, c); | ||
| r = 1; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Its purpose was to check whether the character is present in the font table. That functionality has been moved to writeDigitAscii() where the font table is accessed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the
writeDigitAscii()function from reading outside the bounds of the font table. Values outside the printable range are printed as blanks.This also fixes a
-Wtype-limitswarning accidentally introduced in #41, on platforms wherecharis a signed 8 bit value. This was caused by the range comparison to 127 always being 'true' due to the limits of the type.