Metro_RP2350_Minesweeper: Refactor for USB mouse library and new core USB errors #3118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RetiredWizard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a little more experience with the Adafruit_usb_host_mouse library it turned out not to be too hard to update this to the higher level mouse approach.
This became more pressing when the core started raising errors when a device.manufacturer couldn't be retrieved as the loop we were using to wait for the mouse to become ready wasn't catching any errors but instead, simply checking for a non-None response. We could have just started testing for the error but using the higher level library seemed like a better route.
I still hope to update minesweeper with the right mouse button feature but that's behind a couple other projects I'm working on at the moment.