Follow datasheet when finishing file playback#64
Open
TheNitek wants to merge 1 commit intoadafruit:masterfrom
Open
Follow datasheet when finishing file playback#64TheNitek wants to merge 1 commit intoadafruit:masterfrom
TheNitek wants to merge 1 commit intoadafruit:masterfrom
Conversation
Contributor
|
@TheNitek the PR has conflicts, do you want to resolve them and get this moving or close it? I can't see the conflicts because apparently they've been deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the behaviour recommended by the datasheet when playing a file (send endFillBytes and Cancel playback) to bring VS1053 in correct state after playback and prevent
playingMusicfrom becoming false while VS1053 is still playing data from the buffer (currently there is no way to tell if there is still music playing!)