Added ESP32 interrupt based buffer feeding#73
Closed
juergenpabel wants to merge 1 commit intoadafruit:masterfrom
juergenpabel:master
Closed
Added ESP32 interrupt based buffer feeding#73juergenpabel wants to merge 1 commit intoadafruit:masterfrom juergenpabel:master
juergenpabel wants to merge 1 commit intoadafruit:masterfrom
juergenpabel:master
Conversation
|
Why is this not merged? |
Author
Don't know - the project for which I made this PR has been completed for a long time; I didn't even remember this PR... |
Member
|
this didnt pass CI, lets try to run it again and see what happens |
Member
|
@juergenpabel can you rebase to |
Author
Sorry, I already deleted that repository. I created a new fork, ported the patch and created a new PR that will be the continuation of this PR (PR #77). Thus closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ESP32 compatible interrupt buffer feeder (based on a task running on the other ESP32 core) that was originally implemented based on v1.0.4: https://github.com/danclarke/Adafruit_VS1053_Library/
I merely ported the changes (for this PR).