compatibility with Arduino UNO R4 Wifi board#95
Open
motazEmad wants to merge 2 commits intoadafruit:masterfrom
Open
compatibility with Arduino UNO R4 Wifi board#95motazEmad wants to merge 2 commits intoadafruit:masterfrom
motazEmad wants to merge 2 commits intoadafruit:masterfrom
Conversation
faced compilation errors when compiling the library with Arduino R4 Uno Wifi:
1. fatal error: wiring_private.h: No such file or directory
#include "wiring_private.h"
2. Arduino.h:75:92: error: cannot convert 'volatile uint16_t* {aka volatile short unsigned int*}' to 'PortReg* {aka volatile long unsigned int*}' in assignment
#define portOutputRegister(port) &(((R_PORT0_Type *)IOPORT_PRV_PORT_ADDRESS(port))->PODR)
Adafruit_VS1053.cpp:332:16: note: in expansion of macro 'portOutputRegister'
clkportreg = portOutputRegister(digitalPinToPort(_clk));
faced compilation errors when compiling the library with Arduino R4 Uno Wifi:
1. fatal error: wiring_private.h: No such file or directory
#include "wiring_private.h"
2. Arduino.h:75:92: error: cannot convert 'volatile uint16_t* {aka volatile short unsigned int*}' to 'PortReg* {aka volatile long unsigned int*}' in assignment
#define portOutputRegister(port) &(((R_PORT0_Type *)IOPORT_PRV_PORT_ADDRESS(port))->PODR)
Adafruit_VS1053.cpp:332:16: note: in expansion of macro 'portOutputRegister'
clkportreg = portOutputRegister(digitalPinToPort(_clk));
|
It's not compiling with minima. Same problem #2. Arduino/libraries/Adafruit_VS1053_Library/Adafruit_VS1053.cpp: In constructor 'Adafruit_VS1053::Adafruit_VS1053(int8_t, int8_t, int8_t, int8_t, int8_t, int8_t, int8_t)': etc... |
|
Is anybody actually maintaining this project? This critical P1 bug fix has been sitting unreviewed for more than a year. |
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
faced compilation errors when compiling the library with Arduino R4 Uno Wifi:
I have seen that it was fixed in another library, I did the same fix in this
2.Adafruit_VS1053.cpp
used pinMode Function instead of portOutputRegister & portInputRegister