Added support for File.read to return -1 preventing infinite loop#99
Open
mwrouse wants to merge 1 commit intoadafruit:masterfrom
Open
Added support for File.read to return -1 preventing infinite loop#99mwrouse wants to merge 1 commit intoadafruit:masterfrom
mwrouse wants to merge 1 commit intoadafruit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File.read()has the potential to return -1. I experience this with cheaper SD Cards.In the case of returning -1,
File.read()will continue to return the same bytes but never advance the position in the file.This causes an infinite loop inside of
Adafruit_VS1053_FilePlayer::feedBuffer_noLockwhere the VS1053 is always ready for data because it's not receiving any.