Featherv2 eink linking #829
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontroller.cpp Feather ESP32 V2 was showing no network interface when submitting displayResponse from e-ink featherwing after initial add
tyeth
commented
Oct 15, 2025
| #include "Wippersnapper_Networking.h" | ||
|
|
||
| // // Global WS instance - defined as platform-specific type in Wippersnapper.cpp | ||
| // extern Wippersnapper_WiFi WS; ///< Global member variable for callbacks |
Member
Author
There was a problem hiding this comment.
Drop this, but leave comment: global WS now is a Wippersnapper_WiFi which comes via Wippersnapper_Networking.h, but needs to be extern'd in each cpp file.
tyeth
commented
Oct 15, 2025
| */ | ||
|
|
||
| #include "Wippersnapper.h" | ||
| #include "Wippersnapper_Networking.h" |
Member
Author
There was a problem hiding this comment.
should be via Wippersnapper.h now so drop this include
tyeth
commented
Oct 15, 2025
Member
Author
There was a problem hiding this comment.
all these need fixing up like esp32 (other Arch builds not tested)
This was referenced Oct 15, 2025
Member
Author
|
Linking issue rearing it's ugly head again in #851 due to calling pingBroker and runNetFSM from displays/controller.cpp |
tyeth
added a commit
to tyeth/Adafruit_Wippersnapper_Arduino
that referenced
this pull request
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to be able to leave comments on the changes