-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add new board: Cytron EDU PICO 2 #10734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi, the build is overflowing on one or more languages. You are freezing a lot of libraries. You could drop some of these:
Look at the pico 2W build and see if there are any native (built-in) modules you might want to turn off to make room. |
dhalbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reduce size
|
Hi! Sorry, I forgot to mention earlier. This board will be used with a guidebook that our team is developing. We planning to freeze in all the required libraries so users don’t have to manually add anything into the lib folder. That’s why you see many libraries included here hahah. There are two more libraries I plan to add OPT4048 (which I already added) and PAJ7620.
I tried to build the uf2 using linux and yeah like you said the size is too large:
Currently I try to remove some of the native (built-in) modules that aren’t used in our guidebook to help reduce the firmware size. |
|
|
|
Hi! Thanks again for the suggestion. We’ve disabled several unused modules and adjusted the firmware flash allocation (similar to Pico W / Pico 2 W). The firmware now takes up about 81% of the allocated space.
thanks |
dhalbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, a question and a suggestion.
| CIRCUITPY_MAX3421E = 0 | ||
| CIRCUITPY_ULAB = 0 | ||
| CIRCUITPY_ZLIB = 0 | ||
| CIRCUITPY_SSL_MBEDTLS = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you still do https with this turned off? I'm surprised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh.. thanks for pointing this out. I just tried running HTTPS-related code, and as expected it doesn’t work. Ill delete this line CIRCUITPY_SSL_MBEDTLS = 0
ports/raspberrypi/boards/cytron_edu_pico_v2_2w/mpconfigboard.mk
Outdated
Show resolved
Hide resolved
dhalbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me after the latest round of changes. If you're ready we can merge!
|
Yes! we are ready to proceed with merge Before we do, I just wanted to follow up briefly on one earlier question to make sure we’re aligned: We’ve added one newly created frozen library (PAJ7620). Would it be OK to include this library in the CircuitPython community bundle? I ask because there is already an existing library for this sensor, but due to some disagreements with the maintainer, we decided to develop and maintain our own version. thanks! |
This is ok, but I looked at deshipu/circuitpython-paj7620#1, and I think you could still work with the library author. His requests are minor, and his comments about vetting AI-generated code reflect appropriate caution. If you do make a new version, you should make it have a different |
|
Ohh okay, noted on that. Thank you! |
Hi, can you please help to add this board?
The product is still under development and will be launched soon.
Let me know if there are any issues with it.
Thank you!