Fix data and options functions for multiple files#51
Closed
brechtcs wants to merge 1 commit intoadamayres:masterfrom
Closed
Fix data and options functions for multiple files#51brechtcs wants to merge 1 commit intoadamayres:masterfrom
data and options functions for multiple files#51brechtcs wants to merge 1 commit intoadamayres:masterfrom
Conversation
|
@brechtcs Why was this PR closed? Solved the issue I had thanks 👍 |
Author
|
Don't remember exactly, but I think it was because this (also unmerged) PR fixes the same issue: #37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you pass in a function as the
dataoroptionsarguments, it only gets called for the first file in a stream. For subsequent files, the return value of that first call is passed to the template.This PR fixes this, so that those functions are now called again for each file in the stream.