Update: remove header image aria-hidden (fixes #126) #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace aria-label with alt - remove aria-hidden - add missing quotes to src and alt values
4 tasks
kirsty-hames
moved this from Assigned
to Needs Reviewing
in adapt_framework: The TODO Board
This was referenced Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
Update
aria-hiddensrcandaltvaluesTesting confirmed an empty alt tag (
alt="") is widely supported by screen readers / browsers to ignore an image without the need foraria-hidden.This is part of a global change in Adapt to use
altinstead ofaria-labelfor image alternative text for consistency across Adapt and to align with best practice.Related