feat(csharp): implement Tag Definition System (WI-1.2) #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add centralized tag definitions with export scope annotations for controlling what data is exported to Databricks telemetry service. Changes: - TelemetryTagAttribute class with TagName, ExportScope, Description, Required properties - TagExportScope enum with None, ExportLocal, ExportDatabricks, ExportAll flags for fine-grained export control - TelemetryEventType enum for ConnectionOpen, StatementExecution, Error - ConnectionOpenEvent with workspace.id, session.id, driver.version, driver.os, driver.runtime, feature.cloudfetch, feature.lz4 tags (excludes sensitive server.address from Databricks export) - StatementExecutionEvent with statement.id, session.id, result.format, result.chunk_count, and other metrics (excludes db.statement) - ErrorEvent with error.type, error.message, error.http_status (excludes error.stack_trace from Databricks export) - TelemetryTagRegistry.ShouldExportToDatabricks() for tag filtering - Comprehensive unit tests (31 tests covering all functionality) This enables explicit control over which Activity tags are exported to Databricks telemetry service vs local diagnostics only. Co-Authored-By: Claude <noreply@anthropic.com>
Mark WI-1.2 Tag Definition System as completed with implementation notes and key design decisions documented. Co-Authored-By: Claude <noreply@anthropic.com>
jadewang-db
requested a deployment
to
azure-prod
GitHub Actions
Waiting
This was referenced Jan 22, 2026
eric-wang-1990
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.