Skip to content

fix: explicitly use Git Bash on Windows #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidavidm merged 1 commit into from
Feb 3, 2026
Merged

fix: explicitly use Git Bash on Windows #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions adbc_drivers_dev/make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,8 +448,11 @@ def build_script(
if platform.system() == "Darwin":
env["MACOSX_DEPLOYMENT_TARGET"] = "11.0"

# for Windows
args = ["bash", "./ci/scripts/build.sh", *args]
args = ["./ci/scripts/build.sh", *args]
if ci and PLATFORM == "windows":
# Force use of Git Bash on GitHub Actions
args = [r"C:\Program Files\Git\bin\bash.EXE", *args]

maybe_build_docker(
repo_root=repo_root,
driver_root=driver_root,
Expand Down