Make Davidson subspace max_subspace_iter parameter available to user#203
Merged
jonasleitner merged 4 commits intoadc-connect:masterfrom Mar 3, 2026
Merged
Conversation
fedy9
changed the title
jonasleitner
force-pushed
the
fix_subspace_diag_param
branch
from
7b9e465 to
f29237e
Compare
jonasleitner
reviewed
Mar 2, 2026
jonasleitner
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the subspace gets to large, the subspace diagonalization of the scipy linear algebra solver may run into the default max iterations. Setting this parameter was not available from the adcc user side