fix: Move email-validator to runtime dependencies #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated types use Pydantic's EmailStr which requires email-validator at runtime. Previously it was only in dev dependencies, causing the CLI to fail with "ModuleNotFoundError: No module named 'email_validator'". 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Added test_cli_imports_successfully to verify that the CLI can import all required dependencies, specifically including types that use EmailStr which requires email_validator. This test would have caught the bug where email_validator was only in dev dependencies. The test imports Contact from brand_manifest which uses EmailStr, triggering Pydantic's validation that requires email_validator to be installed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
added a commit
that referenced
this pull request
Nov 18, 2025
* fix: Move email-validator to runtime dependencies The generated types use Pydantic's EmailStr which requires email-validator at runtime. Previously it was only in dev dependencies, causing the CLI to fail with "ModuleNotFoundError: No module named 'email_validator'". 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test: Add CLI import test to catch missing runtime dependencies Added test_cli_imports_successfully to verify that the CLI can import all required dependencies, specifically including types that use EmailStr which requires email_validator. This test would have caught the bug where email_validator was only in dev dependencies. The test imports Contact from brand_manifest which uses EmailStr, triggering Pydantic's validation that requires email_validator to be installed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves
email-validatorfrom optional dev dependencies to runtime dependencies. The generated Pydantic types useEmailStrwhich requiresemail-validatorat runtime for email validation.Changes
email-validator>=2.0.0to main dependencies inpyproject.tomltest_cli_imports_successfullyto catch missing runtime dependenciesFixes CLI failing with
ModuleNotFoundError: No module named 'email_validator'when importing generated types.🤖 Generated with Claude Code