Fix publisher properties display #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where sales agents showed "0 properties" despite having publishers registered. Changes: - Upgrade @adcp/client from 2.4.1 to 2.5.5 - Migrate PropertiesService to use new AgentClient API - Fix status check to handle "completed" status from executeTask - Use correct AgentConfig fields (agent_uri, name) Results: - Weather Sales Agent now correctly displays weather.com publisher - Properties fetching works reliably with MCP and A2A protocols 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where sales agents showed "0 properties" despite having publishers registered. Clicking on agent cards already worked correctly.
Root Cause
The PropertiesService was using legacy
createMCPClient()andcreateA2AClient()functions which had SSE (Server-Sent Events) compatibility issues, and checking forresult.status === "success"when the new API returns"completed".Changes
@adcp/clientfrom 2.4.1 to 2.5.5AgentClientAPI"completed"status fromexecuteTaskAgentConfigfields (agent_uriinstead ofurl, addednamefield)Testing
Verified that:
Files Modified
package.json- Updated @adcp/client dependencypackage-lock.json- Dependency lock fileserver/src/properties.ts- Migrated to new AgentClient API🤖 Generated with Claude Code