Remove nonexistent templates/ from package.json files list#1
Open
federicobartoli wants to merge 1 commit intoaddyosmani:mainfrom
Open
Conversation
The templates/ directory does not exist in the repository and is not referenced by any source file (scaffolder.js keeps templates inline), so listing it in the "files" field only makes the published tarball manifest misleading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
"files"array inpackage.jsonlists"templates/", but that directory does not exist in the repository, and no source file references it (src/scaffolder.jskeeps its templates inline as string literals). The entry only makes the published tarball manifest misleading.This PR removes the stale entry. No runtime behavior changes.
Test plan
npm pack --dry-runstill includesbin/andsrc/contentssrc/scaffolder.jsdoes not read from atemplates/path (verified via grep fortemplatesacrosssrc/)