Sync branch #4
Merged
Sync branch #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need all the help we can get to fix memory problems. Asan can be helpful.
This should clarify usage of the demo vehicle
This documents how to manually activate a vehicle via gui during runtime of navit
The actual speed of a vehicle on a segment is lower than the maximum speed. On long routes, this difference can add up to significant deviations. This implements an improved estimation that considers the vehicle speed to be less than the maximum possible.
ctx.attr is never read, but it is being written to. The compiler complains about dangling pointers on one of those writes. Removing the attribute entirely from the struct seems the prodent choice, which is implemented by this commit and which resolves the warning.
This clarifies the ifdef usage on HAVE_API_WIN32. By breaking up the ifdef, the syntax becomes sound and the warning disappears
… size distances is to be allocated with count elements and that allows elements with index between 0 and count -1. Without the patch, there is a potential for write out of bounds and the compiler warns about a read out of bounds in line 201. This commit fixes both issues.
This replaces strncpy with strncat in places where string truncation might happen which could cause a non-terminated destination buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Navit!
Before opening a pull request on navit, make sure your commit message follows our guidelines:
https://navit.readthedocs.io/en/trunk/development/commit_guidelines.html
and that your code is compliant with out coding style guidelines:
https://navit.readthedocs.io/en/trunk/development/programming_guidelines.html