This repository was archived by the owner on Mar 21, 2026. It is now read-only.
fix: minor cosmetic fixes#34
Merged
adhityaravi merged 6 commits intomainfrom Dec 20, 2025
Merged
Conversation
adhityaravi
force-pushed
the
chore/fix_cosmetics
branch
from
da6783f to
69b20d8
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements minor cosmetic fixes across multiple files, primarily focusing on updating descriptions from "Semantic retrieval for architectural knowledge" to "A fast semantic search and retrieval engine", consolidating theme management, refactoring the TUI architecture, and organizing imports.
Key changes:
- Updated project descriptions and help text throughout the codebase
- Refactored TUI theme system with a new modular theme architecture
- Moved import statements to appropriate locations for better organization
- Removed unused widget and modal files in favor of consolidated approach
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/gundog/src/gundog/_embedder_onnx.py | Moved logging import to top-level |
| packages/gundog/src/gundog/_cli.py | Added version callback with package info display |
| packages/gundog/src/gundog/init.py | Updated module docstring description |
| packages/client/src/gundog_client/_tui/app.tcss | Replaced hardcoded colors with theme variables |
| packages/client/src/gundog_client/_tui/_widgets/_status.py | Removed unused StatusBar widget |
| packages/client/src/gundog_client/_tui/_widgets/_search.py | Removed unused SearchInput widget |
| packages/client/src/gundog_client/_tui/_widgets/_results.py | Removed unused ResultsPane widget |
| packages/client/src/gundog_client/_tui/_widgets/init.py | Removed widget exports |
| packages/client/src/gundog_client/_tui/_themes/_dracula.py | Added new theme definition module |
| packages/client/src/gundog_client/_tui/_themes/init.py | Added theme exports |
| packages/client/src/gundog_client/_tui/_theme.py | Refactored to use modular theme system |
| packages/client/src/gundog_client/_tui/_modals/_preview.py | Removed unused PreviewModal |
| packages/client/src/gundog_client/_tui/_modals/_input.py | Updated to use new Colors enum |
| packages/client/src/gundog_client/_tui/_modals/_index.py | Removed unused IndexModal |
| packages/client/src/gundog_client/_tui/_modals/_help.py | Removed unused HelpModal |
| packages/client/src/gundog_client/_tui/_modals/init.py | Updated modal exports |
| packages/client/src/gundog_client/_tui/_help.py | Added new help text constant |
| packages/client/src/gundog_client/_tui/_enums.py | Removed unused ResultSection enum |
| packages/client/src/gundog_client/_tui/_constants.py | Removed unused UIConfig class |
| packages/client/src/gundog_client/_tui/_app.py | Updated to use new theme system and consolidated imports |
| packages/client/src/gundog_client/_cli.py | Added version callback and moved imports |
| README.md | Updated demo image URLs to use local assets |
Comments suppressed due to low confidence (1)
packages/client/src/gundog_client/_cli.py:1
- The Colors.ACCENT.value is repeated twice in the same f-string. Consider extracting it to a variable for better maintainability.
"""CLI for gundog client - query, tui, and index listing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes
#27
#30
#31
#29