rename all to files_mindmap2 & update node & change project_dir #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the namespace to Files_MindMap2 and id to files_mindmap2 trough the whole codebase. Updated the package with node. Added some exclude Files for the Release in Makefile Changed the project_dir= variable, as when run in the same folder it does not work. but not sure how the workflow for nextcloud is. (this change might be wrong for that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As i did try to use the current changes they did not work for me. It was missing some changes.
Renaming just mindmap to files_mindmap2 was my decision because files_mindmap2 is more unique to find than just mindmap.
Updated the namespace to Files_MindMap2 and id to files_mindmap2 trough the whole codebase. Updated the package with node.
Added some exclude Files for the Release in Makefile Changed the project_dir= variable, as when run in the same folder it does not work. but not sure how the workflow for nextcloud is. (this change might be wrong)