Skip to content
This repository was archived by the owner on Mar 18, 2019. It is now read-only.

Support sparkey_logiter_valuecmp and API changes.#2

Open
admtnnr wants to merge 3 commits intomasterfrom
compare_value
Open

Support sparkey_logiter_valuecmp and API changes.#2
admtnnr wants to merge 3 commits intomasterfrom
compare_value

Conversation

@admtnnr
Copy link
Owner

@admtnnr admtnnr commented Nov 29, 2014

@spkrka
Copy link

spkrka commented Nov 29, 2014

Not sure it's a good to depend on this yet. It's not set in stone if it will ever be merged, or exactly how it will work. That's why it's called experimental :)

@admtnnr
Copy link
Owner Author

admtnnr commented Nov 29, 2014

No worries, I'll leave it open until it either gets merged or the branch gets deleted, in which case I'll either merge or rebase out the first commit. Sparkey doesn't get too many commits so I figured I'd go ahead and knock it out in the off chance it makes it to master. :)

Though, I did find it odd that the valuecmp function takes two log_readers and the keycmp only takes one (assumes it's shared between the iterators). ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants